Remove blocktag from eth_estimateGas #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some chains like BNB Testnet do not support this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 78.58% 78.49% -0.10%
==========================================
Files 28 28
Lines 4324 4324
Branches 603 603
==========================================
- Hits 3398 3394 -4
- Misses 766 769 +3
- Partials 160 161 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some chains like BNB Testnet do not support this
PR-Codex overview
This PR modifies the
ThirdwebTransaction.csfile to change the way theeth_estimateGasmethod is called, removing the "latest" parameter. This adjustment may impact how gas estimation is performed in the transaction processing.Detailed summary
"latest"parameter from therpc.SendRequestAsync<string>("eth_estimateGas", transaction.Input)call.